[SERVER-75396] Confirm FeatureFlag::isEnabledAndIgnoreFCVUnsafe() usage for security Created: 28/Mar/23  Updated: 29/Oct/23  Resolved: 17/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Jiawei Yang Assignee: Sara Golemon
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-66587 Rename isEnabledAndIgnoreFCV() to be ... Closed
Assigned Teams:
Server Security
Backwards Compatibility: Fully Compatible
Sprint: Security 2023-04-17, Security 2023-05-01
Participants:

 Description   

We formalized the usage of FeatureFlag::isEnabledAndIgnoreFCV() in https://jira.mongodb.org/browse/SERVER-66587. Now every usage of FeatureFlag::isEnabledAndIgnoreFCV() is changed to FeatureFlag::isEnabledAndIgnoreFCVUnsafe() and ask the engineer to add a comment describing why you have to ignore FCV here.

Overall, we expect places that are using FeatureFlag::isEnabledAndIgnoreFCVUnsafe() now to be:

  • isEnabledAndIgnoreFCVUnsafeAtStartup() if this feature flag check is before FCV initialization.
  • Stay isEnabledAndIgnoreFCVUnsafe() if you have a reason, and update your reason in the comment line starting with (Ignore FCV check):
  • Change to isEnabled(FCV).

You can also search for TODO(SERVER-75396) for all places need to revisit



 Comments   
Comment by Githook User [ 17/Apr/23 ]

Author:

{'name': 'Sara Golemon', 'email': 'sara.golemon@mongodb.com', 'username': 'sgolemon'}

Message: SERVER-75396 Update featureFlag check for featureFlagSecurityToken
Branch: master
https://github.com/mongodb/mongo/commit/26ca4cab63eed16430b59b5b6df5dbb71e470248

Generated at Thu Feb 08 06:30:04 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.