[SERVER-75474] network_error_and_txn_override.js doesn't always retry commands that fail with FailedToSatisifyReadPreference error Created: 30/Mar/23  Updated: 29/Oct/23  Resolved: 31/Mar/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Cheahuychou Mao Assignee: Cheahuychou Mao
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: Sharding NYC 2023-04-03
Participants:
Linked BF Score: 162

 Description   

The code for triggering retry is shouldRetryWithNetworkExceptionOverride but it is only invoked in this catch block. So if the command runs successfully here but returns a FailedToSatisfyReadPreference error, then it would not get retried.



 Comments   
Comment by Githook User [ 31/Mar/23 ]

Author:

{'name': 'Cheahuychou Mao', 'email': 'mao.cheahuychou@gmail.com', 'username': 'cheahuychou'}

Message: SERVER-75474 network_error_and_txn_override.js doesn't always retry commands that fail with FailedToSatisifyReadPreference error
Branch: master
https://github.com/mongodb/mongo/commit/f55dc161265aa95040eaeba3fc8138a1503c1c2c

Comment by Githook User [ 31/Mar/23 ]

Author:

{'name': 'Cheahuychou Mao', 'email': 'mao.cheahuychou@gmail.com', 'username': 'cheahuychou'}

Message: Revert "SERVER-75474 network_error_and_txn_override.js doesn't always retry commands that fail with FailedToSatisifyReadPreference error"

This reverts commit 9f39fbfba4c54ebc08b5a0f6fe095f565b4b5cf2.
Branch: master
https://github.com/mongodb/mongo/commit/bc77506cc833fe8a84a03ec20e14999258d73c1a

Comment by Githook User [ 30/Mar/23 ]

Author:

{'name': 'Cheahuychou Mao', 'email': 'mao.cheahuychou@gmail.com', 'username': 'cheahuychou'}

Message: SERVER-75474 network_error_and_txn_override.js doesn't always retry commands that fail with FailedToSatisifyReadPreference error
Branch: master
https://github.com/mongodb/mongo/commit/9f39fbfba4c54ebc08b5a0f6fe095f565b4b5cf2

Generated at Thu Feb 08 06:30:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.