[SERVER-75603] Investigate isQuerySbeCompatible performance impact Created: 03/Apr/23  Updated: 29/Oct/23  Resolved: 12/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0, 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Matt Boros Assignee: Matt Boros
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0
Sprint: QO 2023-04-17
Participants:

 Description   

isQuerySbeCompatible showed up as the cause of +0.61% CPU time growth in a comparison between v6.3 and v6.0. There are a few easy fixes, first there is a tassert followed by an equivalent invariant, then there is potential for an early return. If isQuerySbeCompatible has a noticeable perf impact, these changes are worth making.



 Comments   
Comment by Githook User [ 14/Apr/23 ]

Author:

{'name': 'Matt Boros', 'email': 'matt.boros@mongodb.com', 'username': 'mattBoros'}

Message: SERVER-75603 Allow isQuerySbeCompatible to early return

(cherry picked from commit dc28beedd9f4ef77f5dbd7b173bc437a60780c0d)
Branch: v7.0
https://github.com/mongodb/mongo/commit/0c398956f07468ab2e7911f653d930988e22c933

Comment by Kyle Suarez [ 14/Apr/23 ]

xerograph:~/mongo-dev/mongo ♥ git describe dc28beedd9f4ef77f5dbd7b173bc437a60780c0d
r7.1.0-alpha-39-gdc28beedd9f

I requested backport to 7.0.

Comment by David Storch [ 14/Apr/23 ]

Is the 7.1 fix version correct? If so, should this be backported to the 7.0 branch?

Comment by Githook User [ 12/Apr/23 ]

Author:

{'name': 'Matt Boros', 'email': 'matt.boros@mongodb.com', 'username': 'mattBoros'}

Message: SERVER-75603 Allow isQuerySbeCompatible to early return
Branch: master
https://github.com/mongodb/mongo/commit/dc28beedd9f4ef77f5dbd7b173bc437a60780c0d

Generated at Thu Feb 08 06:30:36 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.