[SERVER-75609] Fail more gracefully if computing telemetry key or storing telemetry fails Created: 03/Apr/23  Updated: 02/Feb/24  Resolved: 26/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Charlie Swanson Assignee: Alyssa Clark
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-85099 Tracking: Milestone 1 Closed
is depended on by SERVER-85105 Tracking: PM-2885 Milestone 0 Closed
is depended on by TOOLS-3291 Investigate changes in SERVER-75609: ... Closed
is depended on by COMPASS-6772 Investigate changes in SERVER-75609: ... Closed
Documented
is documented by DOCS-16071 Investigate changes in SERVER-75609: ... Closed
Assigned Teams:
Query Optimization
Backwards Compatibility: Fully Compatible
Participants:

 Description   

We've had a couple instances where we either fail to collect telemetry for a certain query, or fail to redact a certain query. Currently failing to record telemetry tasserts - which would fail the operation in production. Failing to redact telemetry will tassert in a debug build, and log a warning in an optimized/release build. I think the recording logic (first one) should match this redaction logic (second one) to make it a bit safer.



 Comments   
Comment by Githook User [ 02/Feb/24 ]

Author:

{'name': 'Erin Zhu', 'email': 'erin.zhu@mongodb.com', 'username': 'erinzhu001'}

Message: SERVER-86118 Query Stats Backport to 7.0 Batch #2

Includes community changes from
SERVER-73907 Ensure telemetry command succeeds after raising FCV
SERVER-75609 Graceful telemetry failures and error tracking
SERVER-75156 separate queryShape from telemetryKey for find requests
SERVER-76610 account for queryShape nesting in telemetry store key
SERVER-76367: Abstract request-specific shapifying logic into RequestShapifiers
SERVER-76424 Replace 'redact' with 'hmac' in $telemetry syntax
SERVER-76781: Decouple opdebug metric collection from telemetry
SERVER-76208 support query shape serialization in IDL for types with custom serializers
with querystats related serialization/redaction changes from
SERVER-72687 Support for $out to Time-series collections

and enterprise changes from
SERVER-76610 account for queryShape nesting in telemetry store key
SERVER-76424 Replace 'redact' with 'hmac' in $telemetry syntax

GitOrigin-RevId: f424d1b1848f85581a870c061b1231219748c00c
Branch: v7.0
https://github.com/mongodb/mongo/commit/5dc8bc61dfdc550f8d643a4db5d3564a21e24245

Comment by Githook User [ 26/Apr/23 ]

Author:

{'name': 'Alyssa Wagenmaker', 'email': 'alyssa.wagenmaker@mongodb.com', 'username': 'awagenmaker'}

Message: SERVER-75609 Graceful telemetry failures and error tracking
Branch: master
https://github.com/mongodb/mongo/commit/9ddfa200ab0a5a80c3c2996f8ef325d91eaf35ce

Comment by Charlie Swanson [ 21/Apr/23 ]

Unlinking from SERVER-75596 since it looks like that one will take a bit longer, and we can just deal with the merge conflicts in SERVER-75596

Generated at Thu Feb 08 06:30:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.