[SERVER-75617] Make case fallthroughs explicit Created: 03/Apr/23  Updated: 29/Oct/23  Resolved: 04/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Matt Kneiser Assignee: Matt Kneiser
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-55204 Opt in to -Wimplicit-fallthrough in s... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2023-04-17
Participants:

 Comments   
Comment by Matt Kneiser [ 04/Apr/23 ]

The two cases I found are considered trivial and the annotation isn't required. If any code is present in a fallthrough case, then gcc/clang would warn.

Comment by Matt Kneiser [ 04/Apr/23 ]

Discovered just now that there was a large effort to convert to the [[fallthrough]] attribute in SERVER-55204. The SConscript change must be broken because 1 change has made it in the past year after the conversion and 1 use pre-existed the change and went by uncaught.

Comment by Githook User [ 04/Apr/23 ]

Author:

{'name': 'Matt Kneiser', 'email': 'matt.kneiser@mongodb.com', 'username': 'themattman'}

Message: SERVER-75617 Make fallthroughs explicit using the new attribute
Branch: master
https://github.com/mongodb/mongo/commit/83b7d74f7d9e5eae7caf5c958f25fe65a170b5bd

Generated at Thu Feb 08 06:30:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.