[SERVER-75629] Remove MutableDocument::newStorageWithBson() Created: 03/Apr/23  Updated: 29/Oct/23  Resolved: 07/Jul/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Minor - P4
Reporter: Romans Kasperovics Assignee: Foteini Alvanaki
Resolution: Fixed Votes: 0
Labels: neweng, quick-tech-debt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Execution
Backwards Compatibility: Fully Compatible
Sprint: QE 2023-07-24
Participants:

 Description   

The method has limited usage where it is seemingly replaceable with MutableDocument::reset().



 Comments   
Comment by Githook User [ 07/Jul/23 ]

Author:

{'name': 'Foteini Alvanaki', 'email': 'foteini.alvanaki@mongodb.com', 'username': ''}

Message: SERVER-75629 Replace newStorageWithBson() with reset()
Branch: master
https://github.com/mongodb/mongo/commit/3671be3f9806ea908e35b66aa9c9ec409acc23f1

Comment by Kyle Suarez [ 05/Apr/23 ]

Reopening and flagging for re-triage.

Comment by Romans Kasperovics [ 05/Apr/23 ]

Hi kyle.suarez@mongodb.com, I think it makes sense to keep the public API minimal and remove redundancies. The effort in this case is very low, because there are only two usages.

Comment by Kyle Suarez [ 04/Apr/23 ]

romans.kasperovics@mongodb.com, after a quick look at the triage meeting, there are two usages of this function. We did not think that the benefit of replacing the usages was worth the effort / validation, but if you disagree, please say so and we will reopen and retriage.

Generated at Thu Feb 08 06:30:40 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.