[SERVER-75754] Consider moving query.planCacheTotalSizeEstimateBytes and query.planCacheTotalQueryShapes into query.planCache sub-document. Created: 06/Apr/23  Updated: 29/Oct/23  Resolved: 19/Sep/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0

Type: Improvement Priority: Minor - P4
Reporter: Anton Korshunov Assignee: James Harrison
Resolution: Fixed Votes: 0
Labels: query-product-scope-1, query-product-urgency-3, query-product-value-3
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by COMPASS-7229 Investigate changes in SERVER-75754: ... Closed
Documented
is documented by DOCS-16389 Investigate changes in SERVER-75754: ... Closed
Assigned Teams:
Query Optimization
Backwards Compatibility: Minor Change
Participants:

 Description   

In SERVER-70025 we introduced 4 new plan cache counters which are surfaced via query.planCache sub-document.

We should consider moving all plan cache related counters into the query.planCache sub-document to group them logically together.

The two which are currently housed in the query document are:

  • query.planCacheTotalSizeEstimateBytes
  • query.planCacheTotalQueryShapes


 Comments   
Comment by Githook User [ 18/Sep/23 ]

Author:

{'name': 'James Harrison', 'email': '00jamesh@gmail.com', 'username': 'jameseh96'}

Message: SERVER-75754 Move planCache counters into planCache sub-document
Branch: master
https://github.com/mongodb/mongo/commit/d4bc2f8cc648f9a991b38b5392bc4fa8556aaf4b

Comment by Githook User [ 14/Sep/23 ]

Author:

{'name': 'James Harrison', 'email': '00jamesh@gmail.com', 'username': 'jameseh96'}

Message: SERVER-75754 Move planCache counters into planCache sub-document

The counters:
query.planCacheTotalSizeEstimateBytes
query.planCacheTotalQueryShapes

are both planCache specific; for consistency with other planCache
counters (e.g., hits, misses), move these to:

query.planCache.totalSizeEstimateBytes
query.planCache.totalQueryShapes

This leaves the planCache subdocument appearing as follows:

"planCache" : {
"totalQueryShapes" : NumberLong(0),
"totalSizeEstimateBytes" : NumberLong(0),
"classic" :

{ "hits" : NumberLong(0), "misses" : NumberLong(2) }

,
"sbe" :

{ "hits" : NumberLong(0), "misses" : NumberLong(0) }

},

These counters are not specific to classic/sbe.
Branch: SERVER-75754
https://github.com/mongodb/mongo/commit/26e0db2f1315f15c3412c0015289cc1a663d1b15

Comment by Ana Meza [ 18/Apr/23 ]

Passing to Product-Triage, we are looking for a second opinion about doing this work or not?

Generated at Thu Feb 08 06:30:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.