[SERVER-75787] remove std::function reference from repl::logInsertOps Created: 06/Apr/23 Updated: 29/Oct/23 Resolved: 13/Apr/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Execution Team 2023-04-17 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
repl::logInsertOps() accepts getDestinedRecipientFn which is defined by the only caller (in OpObserverImpl) to be a wrapper around ShardingWriteRouter::getReshardingDestinedRecipient(). We make this dependency clearer by replacing the std::function with a direct call to ShardingWriteRouter without incurring any additional explicit link time dependency on shard_role_api (since the library containing oplog.cpp has an existing dependency on shard_role). |
| Comments |
| Comment by Githook User [ 13/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: This removes the indirection from the wrapper function and clarifies the |
| Comment by Githook User [ 12/Apr/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |