[SERVER-75847] optimize includes in IDL generated files Created: 07/Apr/23  Updated: 29/Oct/23  Resolved: 19/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Mark Benvenuto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Security 2023-05-01
Participants:

 Description   

IDL generated files include a lot of files. Some of these are injected by generator.py automatically. At least one, "commands.h", is no longer needed. There are 467 idl files at time of writing so saving time in the generated files will have a cumulative effect.

For example, removing "commands.h" on my machine saved ~2.5s on compilation for a single generated file (fle2_get_count_info_command_gen.cpp) for a debug clang 15 x64 build.

Original:
Time (mean ± σ): 7.070 s ± 0.198 s [User: 6.657 s, System: 0.361 s]
Range (min … max): 6.848 s … 7.501 s 10 runs

New:
Time (mean ± σ): 4.330 s ± 0.077 s [User: 4.093 s, System: 0.205 s]
Range (min … max): 4.248 s … 4.507 s 10 runs



 Comments   
Comment by Githook User [ 19/Apr/23 ]

Author:

{'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}

Message: SERVER-75847 Optimize includes in IDL generated files
Branch: master
https://github.com/mongodb/mongo/commit/1c098f8ef65d3ed088b8d29fb0a36ed5ba72f2cd

Generated at Thu Feb 08 06:31:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.