[SERVER-75858] Add ability to disable IDL duplicate field checks for extra fields Created: 07/Apr/23  Updated: 29/Oct/23  Resolved: 26/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0, 7.0.0-rc4

Type: Task Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Mark Benvenuto
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Problem/Incident
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0
Sprint: Security 2023-04-17, Security 2023-05-01
Participants:
Linked BF Score: 0

 Description   

IDL is used to scan for API version information. IDL was not designed to be used as non-normative scanner for fields. It expects to know all fields and provide guarantees around duplicate fields.

APIParametersFromClient uses a struct to scan for fields in client payloads. These fields are typically absent and because of the duplicate field check for extra fields, a std::set is built with all the field names. Since the command will be processed later in the pipeline, APIParametersFromClient does not need to do duplicate field detection for extra fields.



 Comments   
Comment by Githook User [ 13/Jun/23 ]

Author:

{'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}

Message: SERVER-75858 Fix tests

(cherry picked from commit a6e1dccd481d73cf886fc6ace72e9422c0caef91)
Branch: v7.0
https://github.com/mongodb/mongo/commit/5787600a4f6155aa18eb647841812096cbf8f22c

Comment by Githook User [ 13/Jun/23 ]

Author:

{'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}

Message: SERVER-75858 Add ability to disable IDL duplicate field checks for extra fields

(cherry picked from commit 0d4f88870e20f282f115f094bf9b9db36d8eb4bc)
Branch: v7.0
https://github.com/mongodb/mongo/commit/0d2c7ec6a780604a430b0503c0abf5b4e3a560e7

Comment by Githook User [ 27/Apr/23 ]

Author:

{'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}

Message: SERVER-75858 Fix tests
Branch: master
https://github.com/mongodb/mongo/commit/a6e1dccd481d73cf886fc6ace72e9422c0caef91

Comment by Githook User [ 26/Apr/23 ]

Author:

{'name': 'Mark Benvenuto', 'email': 'mark.benvenuto@mongodb.com', 'username': 'markbenvenuto'}

Message: SERVER-75858 Add ability to disable IDL duplicate field checks for extra fields
Branch: master
https://github.com/mongodb/mongo/commit/0d4f88870e20f282f115f094bf9b9db36d8eb4bc

Generated at Thu Feb 08 06:31:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.