[SERVER-76084] Create targeted tests for command de/serialization Created: 13/Apr/23  Updated: 29/Oct/23  Resolved: 03/Aug/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Hugh Tong (Inactive) Assignee: Hugh Tong (Inactive)
Resolution: Fixed Votes: 0
Labels: auto-reverted, ntdi_must_have
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-70740 Handle expectPrefix option in requests Closed
depends on SERVER-73108 Handle command request/reply serializ... Closed
depends on SERVER-73109 Build idl infrastructure to pass cont... Closed
depends on SERVER-74029 Add SerializationContext to custom de... Closed
depends on SERVER-74284 Fix existing tests for command serial... Closed
depends on SERVER-74897 Change IDL defined commands to call N... Closed
is depended on by SERVER-70547 Create multitenancySupport passthroug... Closed
is depended on by SERVER-78486 Replace parseNamespaceFrom* calls wit... Closed
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: Server Serverless 2023-06-26, Server Serverless 2023-07-10, Server Serverless 2023-07-24, Server Serverless 2023-08-07
Participants:
Linked BF Score: 154
Story Points: 3

 Description   

After the logic exists to serialize and deserialized based on command context, we need to build targeted tests to test this functionality.  This will initially only exist for IDL-generated commands, which we should only need to modify existing tests to adjust for the updated output.

We also need to write tests that test the expectPrefix functionality that was built in SERVER-70740.  We can probably focus on just a couple commands and validate the output for when we provide an expectPrefix == true, == false, and <missing>.
We should also write tests that run commands with both a prefix and $tenant.

There may be some risk in this ticket as tests may uncover issues introduced in previous tickets.



 Comments   
Comment by Githook User [ 03/Aug/23 ]

Author:

{'name': 'Hugh Tong', 'email': 'hugh.tong@mongodb.com', 'username': 'cortrain'}

Message: SERVER-76084 Create targeted tests for command de/serialization
Branch: minh.luu-no_compile_sys-perf
https://github.com/mongodb/mongo/commit/64e56fc3858eafbe9316445722cdd1a888addae9

Comment by Githook User [ 02/Aug/23 ]

Author:

{'name': 'Hugh Tong', 'email': 'hugh.tong@mongodb.com', 'username': 'cortrain'}

Message: SERVER-76084 Create targeted tests for command de/serialization
Branch: master
https://github.com/mongodb/mongo/commit/64e56fc3858eafbe9316445722cdd1a888addae9

Comment by Githook User [ 01/Aug/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com', 'username': ''}

Message: Revert "SERVER-76084 Create targeted tests for command de/serialization"

This reverts commit ec54821f1497badadf2bdc8be5fdbba66034ab10.
Branch: minh.luu-no_compile_sys-perf
https://github.com/mongodb/mongo/commit/b6dd615b377c3de3f5f7f1d78371fc71ae574b76

Comment by Githook User [ 01/Aug/23 ]

Author:

{'name': 'Hugh Tong', 'email': 'hugh.tong@mongodb.com', 'username': 'cortrain'}

Message: SERVER-76084 Create targeted tests for command de/serialization
Branch: minh.luu-no_compile_sys-perf
https://github.com/mongodb/mongo/commit/ec54821f1497badadf2bdc8be5fdbba66034ab10

Comment by xgen-buildbaron-user [ 01/Aug/23 ]

Ticket re-opened due to revert. serverless began a consistent failure of jstests/serverless/native_tenant_data_isolation_expect_prefix.js

Comment by Githook User [ 01/Aug/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com', 'username': ''}

Message: Revert "SERVER-76084 Create targeted tests for command de/serialization"

This reverts commit ec54821f1497badadf2bdc8be5fdbba66034ab10.
Branch: master
https://github.com/mongodb/mongo/commit/b6dd615b377c3de3f5f7f1d78371fc71ae574b76

Comment by Githook User [ 31/Jul/23 ]

Author:

{'name': 'Hugh Tong', 'email': 'hugh.tong@mongodb.com', 'username': 'cortrain'}

Message: SERVER-76084 Create targeted tests for command de/serialization
Branch: master
https://github.com/mongodb/mongo/commit/ec54821f1497badadf2bdc8be5fdbba66034ab10

Comment by xgen-buildbaron-user [ 18/Jul/23 ]

Ticket re-opened due to revert. serverless began a consistent failure of jstests/serverless/native_tenant_data_isolation_expect_prefix.js

Comment by Githook User [ 18/Jul/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com', 'username': ''}

Message: Revert "SERVER-76084 Create targeted tests for command de/serialization"

This reverts commit 32924009a244c02432c5f2af48b13a99463a44bc.
Branch: master
https://github.com/mongodb/mongo/commit/20fc02c34f0f192777217c62cc3e5cb0ebe46155

Comment by Githook User [ 17/Jul/23 ]

Author:

{'name': 'Hugh Tong', 'email': 'hugh.tong@mongodb.com', 'username': 'cortrain'}

Message: SERVER-76084 Create targeted tests for command de/serialization
Branch: master
https://github.com/mongodb/mongo/commit/32924009a244c02432c5f2af48b13a99463a44bc

Comment by xgen-buildbaron-user [ 14/Jul/23 ]

Ticket re-opened due to revert. serverless began a consistent failure of jstests/serverless/native_tenant_data_isolation_expect_prefix.js

Comment by Githook User [ 14/Jul/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com', 'username': ''}

Message: Revert "SERVER-76084 Create targeted tests for command de/serialization"

This reverts commit ae78f9a136285c605ab0ad492bd486463f3d4b33.
Branch: master
https://github.com/mongodb/mongo/commit/5fd663fdde946316892438e473706461bab632e8

Comment by Githook User [ 13/Jul/23 ]

Author:

{'name': 'Hugh Tong', 'email': 'hugh.tong@mongodb.com', 'username': 'cortrain'}

Message: SERVER-76084 Create targeted tests for command de/serialization
Branch: master
https://github.com/mongodb/mongo/commit/ae78f9a136285c605ab0ad492bd486463f3d4b33

Generated at Thu Feb 08 06:31:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.