[SERVER-76131] Move the global fsync state from the FSyncCommand to the FSyncLockThread Created: 14/Apr/23  Updated: 09/Nov/23  Resolved: 06/Sep/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Dianna Hohensee (Inactive) Assignee: Josef Ahmad
Resolution: Duplicate Votes: 0
Labels: intern-friendly, neweng, newgrad, techdebt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-79907 MONGO_REGISTER_COMMAND uniform Comman... Closed
Related
related to SERVER-70444 fsync lock/unlock command fails when ... Closed
related to SERVER-80825 Complete TODO listed in SERVER-76131 Closed
Assigned Teams:
Storage Execution
Sprint: Execution EMEA Team 2023-07-24, Execution EMEA Team 2023-08-07, Execution EMEA Team 2023-08-21, Execution EMEA Team 2023-09-04, Execution EMEA Team 2023-09-18
Participants:

 Description   

Most of this state is cross command logic that is accessed in FSyncCommand, FSyncUnlockCommand and FSyncLockThread. SERVER-70444 will make the mutex around this state global, so that shutdown has access. This ticket should move the rest of the state into the FSyncLockThread, rather than FSyncLockThread and FSyncUnlockCommand continuing to access the state through the fsyncCmd instance – grep for fsyncCmd. around the code.



 Comments   
Comment by Githook User [ 09/Nov/23 ]

Author:

{'name': 'Josef Ahmad', 'email': 'josef.ahmad@mongodb.com', 'username': 'josefahmad'}

Message: SERVER-80825 Remove TODO listed in SERVER-76131
Branch: master
https://github.com/mongodb/mongo/commit/9d954a8518bba6500b72ed7b1015c13cdde7ff6f

Comment by Josef Ahmad [ 06/Sep/23 ]

SERVER-79907 moved the shared FSync logic into a dedicated class, which meets the goal of this ticket.

Comment by Dianna Hohensee (Inactive) [ 18/Apr/23 ]

Also consider changing the code to use WithLock where possible.

Generated at Thu Feb 08 06:31:55 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.