[SERVER-76173] Memoize duplicate field checks in IDL-generated parsers Created: 17/Apr/23 Updated: 02/May/23 Resolved: 02/May/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Vojislav Stojkovic | Assignee: | Vojislav Stojkovic |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | Service Arch 2023-05-01, Service Arch 2023-05-15 |
| Participants: |
| Description |
|
Parsers generated from IDL check the BSON document for duplicate fields. This check is performed more than once for the same BSON document when it's parsed by different parsers. After the first time this check is performed, we should skip subsequent checks. The work done in |
| Comments |
| Comment by Vojislav Stojkovic [ 02/May/23 ] |
|
During the discussion about performance testing accuracy, the consensus was that we should err on the side of inaction. Since this change does not improve ops/sec metrics, there's not enough justification to implement it. |