[SERVER-76208] Support query shape serialization in IDL for types with custom serializers Created: 17/Apr/23  Updated: 02/Feb/24  Resolved: 05/May/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Davis Haupt (Inactive) Assignee: Davis Haupt (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-75399 Update aggregate command (mostly Docu... Closed
Duplicate
is duplicated by SERVER-76357 Support query shape serialization in ... Closed
Problem/Incident
causes SERVER-77336 Make a specific NamespaceStringUtil::... Closed
Backwards Compatibility: Fully Compatible
Sprint: QO 2023-05-01
Participants:
Linked BF Score: 0

 Description   

Custom serializer types like those used in document_source_merge.idl are not properly anonymized with query shape serialization in the IDL currently. This should be fixed before shapify-ing $merge.



 Comments   
Comment by Githook User [ 02/Feb/24 ]

Author:

{'name': 'Erin Zhu', 'email': 'erin.zhu@mongodb.com', 'username': 'erinzhu001'}

Message: SERVER-86118 Query Stats Backport to 7.0 Batch #2

Includes community changes from
SERVER-73907 Ensure telemetry command succeeds after raising FCV
SERVER-75609 Graceful telemetry failures and error tracking
SERVER-75156 separate queryShape from telemetryKey for find requests
SERVER-76610 account for queryShape nesting in telemetry store key
SERVER-76367: Abstract request-specific shapifying logic into RequestShapifiers
SERVER-76424 Replace 'redact' with 'hmac' in $telemetry syntax
SERVER-76781: Decouple opdebug metric collection from telemetry
SERVER-76208 support query shape serialization in IDL for types with custom serializers
with querystats related serialization/redaction changes from
SERVER-72687 Support for $out to Time-series collections

and enterprise changes from
SERVER-76610 account for queryShape nesting in telemetry store key
SERVER-76424 Replace 'redact' with 'hmac' in $telemetry syntax

GitOrigin-RevId: f424d1b1848f85581a870c061b1231219748c00c
Branch: v7.0
https://github.com/mongodb/mongo/commit/5dc8bc61dfdc550f8d643a4db5d3564a21e24245

Comment by Githook User [ 04/May/23 ]

Author:

{'name': 'Davis Haupt', 'email': 'davis.haupt@mongodb.com', 'username': 'davish'}

Message: SERVER-76208 support query shape serialization in IDL for types with custom serializers
Branch: master
https://github.com/mongodb/mongo/commit/04cfd8c72f17cd711fa4c9244c81f0d41cfc3cb5

Comment by Githook User [ 04/May/23 ]

Author:

{'name': 'Davis Haupt', 'email': 'davis.haupt@mongodb.com', 'username': 'davish'}

Message: Revert "SERVER-76208 support query shape serialization in IDL for types with custom serializers"

This reverts commit 1470c88daaa805408f083a1c2f7bb22f1632b5d1.
Branch: master
https://github.com/mongodb/mongo/commit/4dd0a134d5ca678bfa6d1973bd4bf28b0ffc6baa

Comment by Davis Haupt (Inactive) [ 04/May/23 ]

Thanks for the explanation billy.donahue@mongodb.com – this commit's revert is in the queue and I'm working on fixing the underlying issue.

Comment by Billy Donahue [ 04/May/23 ]

Sorry to be the bearer of bad news, but this breaks macOS builds. Explained in comment on PR.

https://github.com/10gen/mongo/commit/1470c88daaa805408f083a1c2f7bb22f1632b5d1#r111814904

Comment by Githook User [ 03/May/23 ]

Author:

{'name': 'Davis Haupt', 'email': 'davis.haupt@mongodb.com', 'username': 'davish'}

Message: SERVER-76208 support query shape serialization in IDL for types with custom serializers
Branch: master
https://github.com/mongodb/mongo/commit/1470c88daaa805408f083a1c2f7bb22f1632b5d1

Generated at Thu Feb 08 06:32:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.