[SERVER-76268] Move all unrelated work out of OpObserverImpl into a miscellaneous FallbackOpObserver Created: 18/Apr/23  Updated: 29/Oct/23  Resolved: 03/May/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Matt Kneiser Assignee: Matt Kneiser
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-76369 Accumulate state among early OpObservers Closed
Related
related to SERVER-66612 Split up OpObserverImpl Open
related to SERVER-76563 Streamline OpObserverImpl::_onReplica... Closed
is related to SERVER-74121 Streamline logical branches in opObse... Backlog
Backwards Compatibility: Minor Change
Sprint: Execution Team 2023-05-15
Participants:

 Description   

OpObserverImpl has far too many dependencies that are unnecessary.

There are many code snippets that have bloated this entity that should be mechanically separated out and put into other OpObserver(s). For the purposes of this ticket and breaking the immediate dependency on OpObserverImpl, I will move all this code into a catch-all OpObserver. A future author could consider breaking these up into more logical blocks.

Primarily, OpObserverImpl should have no need to communicate with these entities:

  • Scope
  • MongoDSessionCatalog
  • ReadWriteConcernDefaults
  • LogicalTimeValidator?


 Comments   
Comment by Githook User [ 03/May/23 ]

Author:

{'name': 'Matt Kneiser', 'email': 'matt.kneiser@mongodb.com', 'username': 'themattman'}

Message: SERVER-76268 Create FallbackOpObserver
Branch: master
https://github.com/mongodb/mongo/commit/8037d49bdffb50394fbcb5d6af624d02022eb656

Generated at Thu Feb 08 06:32:15 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.