[SERVER-76367] Introduce interface to abstract out query request telemetry key generation and serialization Created: 20/Apr/23  Updated: 02/Feb/24  Resolved: 28/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Will Buerger Assignee: Will Buerger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-73152 Literal and field name redaction for ... Closed
is depended on by SERVER-76557 Keep RequestShapifiers in telemetry s... Closed
Duplicate
duplicates SERVER-76517 Separate query shape from telemetry k... Closed
Assigned Teams:
Query Optimization
Backwards Compatibility: Fully Compatible
Sprint: QO 2023-05-01
Participants:

 Description   

SERVER-73152 had to avoid introducing a dependency cycle between `op_metrics` (the target telemetry is in) and `pipeline` with a roundabout solution. As cleanup, we should consider creating an interface for each command type to implement (right now find and agg) with at least a method like "makeTelemetryKey". We can then have one function `registerRequest(QueryInstance)` for all request types.



 Comments   
Comment by Githook User [ 02/Feb/24 ]

Author:

{'name': 'Erin Zhu', 'email': 'erin.zhu@mongodb.com', 'username': 'erinzhu001'}

Message: SERVER-86118 Query Stats Backport to 7.0 Batch #2

Includes community changes from
SERVER-73907 Ensure telemetry command succeeds after raising FCV
SERVER-75609 Graceful telemetry failures and error tracking
SERVER-75156 separate queryShape from telemetryKey for find requests
SERVER-76610 account for queryShape nesting in telemetry store key
SERVER-76367: Abstract request-specific shapifying logic into RequestShapifiers
SERVER-76424 Replace 'redact' with 'hmac' in $telemetry syntax
SERVER-76781: Decouple opdebug metric collection from telemetry
SERVER-76208 support query shape serialization in IDL for types with custom serializers
with querystats related serialization/redaction changes from
SERVER-72687 Support for $out to Time-series collections

and enterprise changes from
SERVER-76610 account for queryShape nesting in telemetry store key
SERVER-76424 Replace 'redact' with 'hmac' in $telemetry syntax

GitOrigin-RevId: f424d1b1848f85581a870c061b1231219748c00c
Branch: v7.0
https://github.com/mongodb/mongo/commit/5dc8bc61dfdc550f8d643a4db5d3564a21e24245

Comment by Githook User [ 27/Apr/23 ]

Author:

{'name': 'Will Buerger', 'email': 'will.buerger@mongodb.com', 'username': 'wbuerger46'}

Message: SERVER-76367: Abstract request-specific shapifying logic into RequestShapifiers
Branch: master
https://github.com/mongodb/mongo/commit/26a441e07f3885dc8b3d9ef9b564eb4f5143bded

Comment by Will Buerger [ 26/Apr/23 ]

charlie.swanson@mongodb.com yes!

Comment by Charlie Swanson [ 26/Apr/23 ]

will.buerger@mongodb.com did I get the dependency link right here?

Generated at Thu Feb 08 06:32:31 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.