[SERVER-76398] Consider making AcquisitionPrerequisites::kPretendUnsharded be part of PlacementConcernPlaceholder Created: 21/Apr/23 Updated: 27/Oct/23 Resolved: 05/Jul/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Jordi Serra Torrens | Assignee: | [DO NOT USE] Backlog - Sharding EMEA |
| Resolution: | Works as Designed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Sharding EMEA
|
||||||||
| Participants: | |||||||||
| Comments |
| Comment by Jordi Serra Torrens [ 05/Jul/23 ] |
|
Moving kPretendUnsharded to be under PlacementConcernPlaceholder requires that we change CollectionOrViewAcquisitionRequest to take a PlacementConcernVariant instead of just a normal PlacementConcern. This would make the public API more confusing. The difference between kPretendUnsharded and kLocalCatalogOnlyWithPotentialDataLoss is that the former us used by normal acquisitions through the[ acquireCollection* API|https://github.com/mongodb/mongo/blob/22a5016366c60ea9a195166ebee966ce2c3e6597/src/mongo/db/shard_role.h#L332-L334], and the latter is only ever used internally by acquireCollectionForLocalCatalogOnlyWithPotentialDataLoss which doesn't take a PlacementConcern at all. |