[SERVER-76475] Skip sampleId validation based on testingDiagnosticsEnabled instead of enableTestCommands Created: 24/Apr/23 Updated: 29/Oct/23 Resolved: 24/Apr/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0, 7.0.0-rc1 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Cheahuychou Mao | Assignee: | Cheahuychou Mao |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Operating System: | ALL | ||||
| Backport Requested: |
v7.0
|
||||
| Sprint: | Sharding NYC 2023-05-01 | ||||
| Participants: | |||||
| Description |
|
enableTestCommands is meant to be used for enable more commands not for changing the behavior for testing. That's what testingDiagnosticsEnabled is for. Here is where the check is. |
| Comments |
| Comment by Githook User [ 25/Apr/23 ] |
|
Author: {'name': 'Cheahuychou Mao', 'email': 'mao.cheahuychou@gmail.com', 'username': 'cheahuychou'}Message: (cherry picked from commit 30c2cf0073d86c4e18b0f051178831f4b21274df) |
| Comment by Githook User [ 24/Apr/23 ] |
|
Author: {'name': 'Cheahuychou Mao', 'email': 'mao.cheahuychou@gmail.com', 'username': 'cheahuychou'}Message: |