[SERVER-76563] Streamline OpObserverImpl::_onReplicationRollback Created: 26/Apr/23  Updated: 29/Oct/23  Resolved: 23/May/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Matt Kneiser Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-79998 fold OpObserverImpl::onReplicationRol... Closed
is related to SERVER-76268 Move all unrelated work out of OpObse... Closed
Assigned Teams:
Storage Execution
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2023-05-15, Execution Team 2023-05-29
Participants:

 Description   
  • _onReplicationRollback should be a public member without a leading underscore
  • There are dependencies on LogicalTimeValidator and ReadWriteConcernDefaults that could be removed by pulling out chunks of this behavior and putting into FallbackOpObserver
    • Could then remove link and compile-time dependencies on the relevant libraries and headers.
  • A unit test would need to be moved as well.


 Comments   
Comment by Githook User [ 06/May/23 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-76563 remove OpObserver::_onReplicationRollback() indirection
Branch: master
https://github.com/mongodb/mongo/commit/7387430aa3cd99126167662be55c96c3c469500f

Comment by Githook User [ 05/May/23 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-76563 remove unimplemented AuthOpObserver::getDocumentKey()

Implementation was removed in commit a3316c51e513e941d0765f9e4383c9e79ebb78a5.
Branch: master
https://github.com/mongodb/mongo/commit/69ef061bca8f57eec617c8e607a629bc3a0c8aff

Comment by Githook User [ 05/May/23 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-76563 move OpObserver rollback exception handling from inlined interface function to RollbackImpl
Branch: master
https://github.com/mongodb/mongo/commit/0417f5dae1f8d20caec7646982a49124c2b44c5f

Generated at Thu Feb 08 06:33:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.