[SERVER-7659] Fix Windows XP 32 bit compilation of InterlockedCompareExchange64 Created: 14/Nov/12 Updated: 08/Mar/13 Resolved: 26/Feb/13 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | 2.3.0 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Thor Khan | Assignee: | Unassigned |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
windows xp sp3 32 bits |
||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Participants: | |||||||||
| Description |
|
using intrinsic lets mongodb head compile and run on windows xp 32 bits |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 26/Feb/13 ] |
|
Closed as duplicate of |
| Comment by Ian Whalen (Inactive) [ 15/Nov/12 ] |
|
Hi Thor, in order to incorporate your changes we'd appreciate it if you could open a pull request as described at https://help.github.com/articles/creating-a-pull-request |
| Comment by Thor Khan [ 15/Nov/12 ] |
|
you wrote: |
| Comment by Thor Khan [ 15/Nov/12 ] |
|
I committed the changes at https://github.com/Thor1Khan/mongo.git |
| Comment by Tad Marshall [ 15/Nov/12 ] |
|
Hi Thor, Could you sign the MongoDB Contributor Agreement (http://www.10gen.com/contributor) and then post a pull request for this change? My understanding is that the future does not look bright for Windows XP support in MongoDB, because there are other things introduced in Windows Vista (e.g. condition variables) that we plan to use. Changing from static to dynamic linking is not attractive; is it somehow required to use your approach? Do you know why your change to distlock_test.cpp was needed? MongoDB is pretty limited in 32-bits, and there are Windows-specific issues around memory-mapped files that we were able to sidestep in 64-bit that we can't avoid in 32-bit. But supporting 32-bit platforms for learning the product does help more people become exposed to MongoDB, and Windows XP has been a popular platform, so I understand your desire to get it working again. Tad |
| Comment by Thor Khan [ 15/Nov/12 ] |
|
when compiling using msvc 1600 and using latest boost headers(1_53 trunk) |
| Comment by Tad Marshall [ 14/Nov/12 ] |
|
I edited the title, let me know if it looks right to you. I have not looked at your header yet, but thanks in advance! |
| Comment by Thor Khan [ 14/Nov/12 ] |
|
this was(is being) tested using vc++ 1600 compilers |
| Comment by Thor Khan [ 14/Nov/12 ] |
|
InterlockedComapreExchange64 must be corrected in tile for the sake of search engines |
| Comment by Thor Khan [ 14/Nov/12 ] |
|
It would be nice to be able to correct the title (InterlockedComapreExchange64 ) |