[SERVER-76597] Reported size of TelemetryMetrics is too small Created: 27/Apr/23  Updated: 29/Oct/23  Resolved: 26/Jun/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Charlie Swanson Assignee: Charlie Swanson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-85055 Tracking: M1 Performance improvement ... Closed
is depended on by SERVER-85099 Tracking: Milestone 1 Closed
is depended on by SERVER-85105 Tracking: PM-2885 Milestone 0 Closed
Problem/Incident
Related
related to SERVER-77567 Cap memory size of query stats store ... Closed
is related to SERVER-76330 Use representative query shape in que... Closed
is related to SERVER-76526 Remove cached redacted query from Tel... Closed
Assigned Teams:
Query Optimization
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: QO 2023-06-12, QO 2023-06-26
Participants:
Linked BF Score: 35

 Description   

In the budget estimator for the PartitionedCache we just use a simple sizeof(TelemetryMetrics), but the type now has a BSONObj cmdObj which is not a simple type you can use 'sizeof' to correctly size. The same is true of the NamespaceString (uses a string buffer) and application name, since std::strings are variable size as well. We should include the size of this object (or whatever takes its place in SERVER-76330) to be sure we are properly accounting for memory used. 

 

Also related to SERVER-76526 - right now that BSONObj is left out of this computation as well.



 Comments   
Comment by Githook User [ 22/Jun/23 ]

Author:

{'name': 'Charlie Swanson', 'email': 'charlie.swanson@mongodb.com', 'username': 'cswanson310'}

Message: SERVER-76597 Properly account for query stats store memory
Branch: master
https://github.com/mongodb/mongo/commit/ed58514f49be0065ee72fc89fc1194844857d7b2

Generated at Thu Feb 08 06:33:07 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.