[SERVER-76831] Use CollectionAcquisition in the IndexBuildsCoordinator Created: 04/May/23  Updated: 03/Nov/23

Status: Backlog
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Backlog - Catalog and Routing
Resolution: Unresolved Votes: 0
Labels: PM-2144-QW-Fallout
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-75157 Complete TODO listed in SERVER-73766 Blocked
Assigned Teams:
Catalog and Routing
Sprint: Sharding EMEA 2023-05-29, Sharding EMEA 2023-06-12
Participants:

 Description   

This ticket is to switch the usage of AutoGetCollection for acquireCollection in the IndexBuildsCoordinator.



 Comments   
Comment by Jordi Olivares Provencio [ 04/Jul/23 ]

There are some usages that would warrant a thorough investigation to prove their correctness:

  • In some instances we skip the AutoGetters in favour of raw lock acquisition
  • In various parts of the code we keep passing down CollectionPtr. But those members are also called from other places that have nothing to do. This would require performing some thread-through code so it supports both arguments.
  • Other places summon a CollectionWriter deep within the stack. Which would require threading through the acquisition.
  • And then there's also the fact RSTL is taken out of order in some instances deliberately
Generated at Thu Feb 08 06:33:44 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.