[SERVER-76984] Remove check for !_isInternalClient() in service entry point Created: 10/May/23  Updated: 15/Jan/24  Resolved: 11/May/23

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 7.1.0-rc0, 7.0.6

Type: Task Priority: Major - P3
Reporter: Allison Easton Assignee: Allison Easton
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0
Sprint: Sharding EMEA 2023-05-15
Participants:

 Description   

The check for !_isInternalClient() is redundant because of the checks for authentication that we are doing. Internal clients will be authorized with as __system, which will always have the direct shard operations action type.



 Comments   
Comment by Githook User [ 15/Jan/24 ]

Author:

{'name': 'Allison Easton', 'email': 'allison.easton@mongodb.com', 'username': 'allisoneaston'}

Message: SERVER-75537 Handle direct operations against shards
(cherry picked from commit 627d0074e27f5bd2b7853433f1f5c78cdad356db)

SERVER-76337 Add a server status metric to track unauthorized direct connections to shards
(cherry picked from commit 7fc5589de0c4ee771a58ada749e1261d19f15160)

SERVER-76984 Remove check for !_isInternalClient() in service entry point
(cherry picked from commit da74bce05533353a39a7540dc7a724867ae5cb04)

SERVER-77027 Only check for direct shard connections if sharding is enabled
(cherry picked from commit f9de98ae11d27a246632cd9b5148ef2ad08cd40b)

GitOrigin-RevId: 465e71da0a3b8b5bc4b16ffd3e2c1ed1a70e2bbc
Branch: v7.0
https://github.com/mongodb/mongo/commit/5970527c3fec941729033f93673a42e7e6b1b468

Comment by Githook User [ 11/May/23 ]

Author:

{'name': 'Allison Easton', 'email': 'allison.easton@mongodb.com', 'username': 'allisoneaston'}

Message: SERVER-76984 Remove check for !_isInternalClient() in service entry point
Branch: master
https://github.com/mongodb/mongo/commit/da74bce05533353a39a7540dc7a724867ae5cb04

Generated at Thu Feb 08 06:34:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.