[SERVER-76992] Remove the definition of CertInformationToLog::getDynamicAttributes from the header Created: 10/May/23  Updated: 29/Oct/23  Resolved: 15/Jun/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Mark Benvenuto Assignee: Emilio Alvear Cantu (Inactive)
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Server Security
Backwards Compatibility: Fully Compatible
Sprint: Security 2023-06-12, Security 2023-06-26
Participants:

 Description   

Because CertInformationToLog::getDynamicAttributes is declared in the header, it must be compiled in every file it is used (1000+). This function is expensive to compile because of all of the template instantiations in particular needed for libfmt & logging.

Move the definition of the function into src/mongo/util/net/ssl_manager.cpp.

Definition:
https://github.com/mongodb/mongo/blob/310e84afa411117081c8b49ae152673d08ec597d/src/mongo/util/net/ssl_manager.h#L188-L202



 Comments   
Comment by Githook User [ 13/Jun/23 ]

Author:

{'name': 'Emilio0404', 'email': 'emilio.alvear@hotmail.com', 'username': 'Emilio0404'}

Message: SERVER-76992 Moved definition of function CertInformationToLog::getDynamicAttributes from header to implementation
Branch: master
https://github.com/mongodb/mongo/commit/769e4d0e0a39eade4762e83b3a10b938b2a333ec

Generated at Thu Feb 08 06:34:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.