[SERVER-77267] Investigate if using std::shared_ptr<FindCommandRequest> can help speed up query shape stats collection Created: 18/May/23  Updated: 07/Jul/23  Resolved: 06/Jun/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: Charlie Swanson Assignee: Davis Haupt (Inactive)
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-85055 Tracking: M1 Performance improvement ... Closed
Related
related to SERVER-76329 Use representative query shape in tel... Closed
is related to SERVER-76042 Avoid re-parsing match, sort and proj... Closed
Assigned Teams:
Query Optimization
Operating System: ALL
Participants:

 Description   

From a code review comment on SERVER-76042:

   FindCommandRequest _request;  // We make a copy of FindCommandRequest

jacob.evans@mongodb.com: how else would we do this? should we be thinking of a shared_ptr rather than copying?

let's attempt that in this ticket and see if it shows up in the numbers.



 Comments   
Comment by Davis Haupt (Inactive) [ 31/May/23 ]

The questionable line is no longer present in the patch for SERVER-76329. If that remains the case when that patch goes in, I'll close this as a duplicate.

Generated at Thu Feb 08 06:35:00 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.