[SERVER-77293] Make CanonicalQuery::canonicalize() throw exceptions rather than return non-OK statuses Created: 18/May/23  Updated: 25/May/23  Resolved: 25/May/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Charlie Swanson Assignee: Backlog - Query Optimization
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-77294 Get rid of "CanonicalQuery::init()" p... Closed
Related
is related to SERVER-76042 Avoid re-parsing match, sort and proj... Closed
Assigned Teams:
Query Optimization
Participants:

 Description   

This was considered as part of SERVER-76042. It would simplify most of the call sites who just 'uassertStatusOK()' anyway, and will also simplify some of the implementation. It also allows the linked follow-up ticket.

Warning: I attempted this and the patch got quite large. It is conceptually simple though and there wasn't anything that came up that seemed super risky. There were a couple try/catches to preserve behavior in an "if not OK" branch, but I recall it was exclusively error message context, and perhaps breaking a retry cycle in one place.


Generated at Thu Feb 08 06:35:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.