[SERVER-77327] Rename verify() to MONGO_verify() to avoid name clashes Created: 19/May/23  Updated: 29/Oct/23  Resolved: 23/May/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0, 7.0.0-rc3

Type: Task Priority: Major - P3
Reporter: Colin Stolley Assignee: Colin Stolley
Resolution: Fixed Votes: 0
Labels: perf-70-blocker
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Backports
Depends
Sub-Tasks:
Key
Summary
Type
Status
Assignee
SERVER-77328 remove verify() from enterprise module Sub-task Closed Colin Stolley  
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0
Participants:
Linked BF Score: 105

 Description   

We define a (now deprecated) macro called verify(), which is similar to invariant(). verify() is a very common name for functions, so it clashes with third party code sometimes, notably with abseil's btree_set.

It would be helpful to rename verify() to mongo_verify() to avoid name clashes.

This requires changes to both mongodb and the enterprise module.



 Comments   
Comment by Githook User [ 26/May/23 ]

Author:

{'name': 'Colin Stolley', 'email': 'colin.stolley@mongodb.com', 'username': 'ccstolley'}

Message: SERVER-77327: replace verify() with MONGO_verify()
Branch: v7.0
https://github.com/mongodb/mongo/commit/6f400ff7e51cc9a75baf44c90b073cf3684943be

Comment by Githook User [ 23/May/23 ]

Author:

{'name': 'Colin Stolley', 'email': 'colin.stolley@mongodb.com', 'username': 'ccstolley'}

Message: SERVER-77327: replace verify() with MONGO_verify()
Branch: master
https://github.com/mongodb/mongo/commit/4ab4546310c38e492dd70e0a73740494e7e3f112

Generated at Thu Feb 08 06:35:11 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.