[SERVER-77341] cpuload add the time consuming statistics and mongos add cpuload command support Created: 22/May/23 Updated: 29/Oct/23 Resolved: 07/Jul/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | y yz | Assignee: | George Wangensteen |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Service Arch
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Service Arch 2023-07-10 | ||||||||
| Participants: | |||||||||
| Description |
|
perfect befor:
perfect after:
|
| Comments |
| Comment by Githook User [ 07/Jul/23 ] |
|
Author: {'name': '3058078489@qq.com', 'email': '3058078489@qq.com', 'username': 'y123456yz'}Message: Closes https://github.com/mongodb/mongo/pull/1546 Signed-off-by: George Wangensteen <george.wangensteen@mongodb.com> |
| Comment by y yz [ 30/Jun/23 ] |
|
I have optimized the code according to your comment, thanks
|
| Comment by George Wangensteen [ 29/Jun/23 ] |
|
HI 1147952115@qq.com , thanks for the explanation. I left some small comments on the PR about a change we need to make before we can merge. We can continue the conversation on the PR as we go through code-review. Thanks very much for your contribution; we appreciate it! |
| Comment by y yz [ 27/Jun/23 ] |
|
hi, george.wangensteen@mongodb.com
Background is as follows: 2. We will not use these services online until test(contain cpuload) are OK, we will use enableTestCommands to start our tests. couload return value increased time statistics can help us to test and analyze server CPU performance. 3. Since we use different server of mongos and mongod, we need to conduct cpuload analysis on mongos, so mongos also needs to support the cpuload command.
thanks |
| Comment by George Wangensteen [ 26/Jun/23 ] |
|
Hi 1147952115@qq.com , thanks for the contribution! I took an initial look at the PR you provided, but before I reviewed it I wanted to clarify the motivations here. Currently, we only use the cpuLoad command as a canary and for noise-analysis during performance testing, to get data on the actual CPU independent of the mongoDB workload. The command is test-only, which means that it can only be run when the server is started-up in "testing-mode" / with "enableTestCommands" parameter set to true. Since this command can't be run on a production server (i.e. one without testing mode enabled), I'd like to understand the use-case of adding this to mongos and changing the output before reviewing, to make sure this is the best solution for you. Could you tell me your use-case for this change? Thanks, George |
| Comment by Chris Kelly [ 22/May/23 ] |
|
Thanks for the pull request, 1147952115@qq.com! I'm passing this along to the relevant team to take a look. |
| Comment by y yz [ 22/May/23 ] |
|
this is an improved feature, but Ican not choose "Improvement" button.
|
| Comment by y yz [ 22/May/23 ] |
|
the perfect code: https://github.com/mongodb/mongo/pull/1546 |
| Comment by y yz [ 22/May/23 ] |
|
|