[SERVER-77379] Cleanup IndexCatalogImpl::_deleteIndexFromDisk() code path to use const IndexCatalogEntry instead of shared_ptr Created: 22/May/23 Updated: 05/Oct/23 Resolved: 05/Oct/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Gregory Wlodarek | Assignee: | David Dominguez Sal |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Storage Execution
|
||||||||
| Sprint: | Execution Team 2023-06-12, Execution EMEA Team 2023-10-16 | ||||||||
| Participants: | |||||||||
| Description |
|
Additional cleanup work to be done after |
| Comments |
| Comment by David Dominguez Sal [ 05/Oct/23 ] |
|
The proposed refactoring requires still to use the shared pointer at the bottom level. Removing the shared pointer would imply that we use ident instead of the original class, which makes the code less readable as it is a very low level construct. |
| Comment by David Dominguez Sal [ 04/Oct/23 ] |
|
In the current version, the shared pointer is stored in _entries collection in UncommittedCatalogUpdates. The elements of the collection expect a shared pointer
|