[SERVER-77435] rename/document some resmoke arguments to be more intuitive Created: 24/May/23  Updated: 23/Jan/24

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Trevor Guidry Assignee: Trevor Guidry
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Correctness
Sprint: Build and Correctness OnDeck
Participants:

 Description   

runNoFeatureFlagTests should be renamed to excludeUnreleasedFeatureFlagTests

 

runAllFeatureFlagTests should be renamed to  activateUnreleasedFeatureFlags

The old arguments should be kept for backwards compatibility and deprecated with warnings about using the new options instead.

 

The --help for these options should also be updated, here are some descriptions that might help.

 

Using -runNoFeatureFlagTests will simply add all “featureFlags” (entries in all_feature_flags.txt ) to the -excludeWithAnyTags argument. If you use this argument & your “featureFlag” does not have a default version, it’s corresponding tests are guaranteed to be ignored during testing. This is an override used for multiversion testing.

Using --runAllFeatureFlagTests will activate all “featureFlags” from the all_feature_flags.txt file but does not actually “runAllFeatureFlagTests” as indicated by the name and resmoke arg description. This does not affect includes/excludes or what tests run, it simply “turns on” all feature flags.

 

There is another ticket about changing the name of all_feature_flags.txt to unreleased_feature_flags.txt in case that one gets done first and this description becomes outdated.



 Comments   
Comment by Alex Neben [ 24/May/23 ]

tausif.rahman@mongodb.com 's write up https://mongodb.slack.com/archives/GPZ8BPS3E/p1684890097442469?thread_ts=1684880129.230469&cid=GPZ8BPS3E should be comitted to the codebae via resmoke --help and/or src/mongo/db/repl/FCV_AND_FEATURE_FLAG_README.md

Generated at Thu Feb 08 06:35:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.