[SERVER-77457] Enable $trunc SBE implementation by default Created: 24/May/23  Updated: 29/Oct/23  Resolved: 14/Jun/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Task Priority: Major - P3
Reporter: David Storch Assignee: Amr Elhelw
Resolution: Fixed Votes: 0
Labels: neweng
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File ExpressionTrunc-classic.png     PNG File ExpressionTrunc-sbe.png    
Issue Links:
Depends
Assigned Teams:
Query Execution
Backwards Compatibility: Fully Compatible
Sprint: QE 2023-06-26
Participants:

 Description   

At the moment, $trunc is implemented for SBE but is guarded behind featureFlagSbeFull. Assuming the performance results look good, then we should enable $trunc in SBE by default in the next release. This should be as simple as removing the line of code referenced above that marks the expression with SbeCompatibility::flagGuarded during parsing.



 Comments   
Comment by Githook User [ 14/Jun/23 ]

Author:

{'name': 'Amr Elhelw', 'email': 'amr.elhelw@mongodb.com', 'username': 'aelhelw'}

Message: SERVER-77457 Enable $trunc SBE implementation by default
Branch: master
https://github.com/mongodb/mongo/commit/ec4e591e70b21687a906b3404800b61826d2aefd

Comment by Amr Elhelw [ 13/Jun/23 ]

Just added some performance results obtained from go/perf-trends for ExpressionTrunc on both SBE and classic engine. Seems safe to enable the SBE implementation by default

Comment by Amr Elhelw [ 07/Jun/23 ]

david.storch@mongodb.com I'm not sure if it will happen in the current sprint or the next one. I only submitted some benchmark changes yesterday, so would like to wait and see the performance results. I'll probably take care of it myself.

Comment by David Storch [ 07/Jun/23 ]

amr.elhelw@mongodb.com did you mean to schedule this into the current sprint, or are you going to find a different assignee?

Generated at Thu Feb 08 06:35:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.