[SERVER-77534] Fix diff finder to handle deleted files correctly Created: 26/May/23  Updated: 29/Oct/23  Resolved: 31/May/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0, 6.0.7, 5.0.19, 4.4.23, 7.0.0-rc3

Type: Improvement Priority: Minor - P4
Reporter: Jeffrey Zambory Assignee: Mikhail Shchatko
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0, v6.0, v5.0, v4.4
Sprint: DAG 2023-05-29, DAG 2023-06-12
Participants:
Story Points: 1

 Description   

The find_changed_files function in the mongo repo currently gets the correct result but does so backwards. It thinks all of the added files were actually deleted, which is incorrect, but then does an incorrect set operation, leading to us finding the added files anyways.

https://github.com/10gen/mongo/blob/1f8261ededebc24680a2e2c25421970968356bc5/buildscripts/patch_builds/change_data.py#L74

We should update this function to find the correct files for the correct reason.

https://parsley.mongodb.com/evergreen/mongodb_mongo_master_enterprise_rhel_80_64_bit_dynamic_all_feature_flags_required_security_patch_only_lint_fuzzer_sanity_patch_patch_8c64458511a257877e99a2e78278db1ea3bd14b8_645926439ccd4eda0bf4fb79_23_05_09_22_41_24/0/task?bookmarks=0,364&shareLine=111

 



 Comments   
Comment by Githook User [ 31/May/23 ]

Author:

{'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}

Message: SERVER-77534 Fix diff finder to handle deleted files correctly

(cherry picked from commit be9568dd3c96f5727ef8cb0cfc598164e5bba69b)
Branch: v7.0
https://github.com/mongodb/mongo/commit/2a19de938f305050d5cda81f38907658f3735407

Comment by Githook User [ 31/May/23 ]

Author:

{'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}

Message: SERVER-77534 Fix diff finder to handle deleted files correctly

(cherry picked from commit be9568dd3c96f5727ef8cb0cfc598164e5bba69b)
Branch: v6.0
https://github.com/mongodb/mongo/commit/e45d604397d310341c5eb188acdaf51190308a10

Comment by Githook User [ 31/May/23 ]

Author:

{'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}

Message: SERVER-77534 Fix diff finder to handle deleted files correctly

(cherry picked from commit be9568dd3c96f5727ef8cb0cfc598164e5bba69b)
Branch: v5.0
https://github.com/mongodb/mongo/commit/7cf1370433b6a6e5aed3a6be335b3b1bd7258c07

Comment by Githook User [ 31/May/23 ]

Author:

{'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}

Message: SERVER-77534 Fix diff finder to handle deleted files correctly

(cherry picked from commit be9568dd3c96f5727ef8cb0cfc598164e5bba69b)
Branch: v4.4
https://github.com/mongodb/mongo/commit/895eee3644ee387e3604b1996ffdf5c0b9669141

Comment by Githook User [ 31/May/23 ]

Author:

{'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}

Message: SERVER-77534 Fix diff finder to handle deleted files correctly
Branch: master
https://github.com/mongodb/mongo/commit/be9568dd3c96f5727ef8cb0cfc598164e5bba69b

Generated at Thu Feb 08 06:35:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.