[SERVER-77534] Fix diff finder to handle deleted files correctly Created: 26/May/23 Updated: 29/Oct/23 Resolved: 31/May/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0, 6.0.7, 5.0.19, 4.4.23, 7.0.0-rc3 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | Jeffrey Zambory | Assignee: | Mikhail Shchatko |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Fully Compatible | ||||
| Backport Requested: |
v7.0, v6.0, v5.0, v4.4
|
||||
| Sprint: | DAG 2023-05-29, DAG 2023-06-12 | ||||
| Participants: | |||||
| Story Points: | 1 | ||||
| Description |
|
The find_changed_files function in the mongo repo currently gets the correct result but does so backwards. It thinks all of the added files were actually deleted, which is incorrect, but then does an incorrect set operation, leading to us finding the added files anyways. We should update this function to find the correct files for the correct reason.
|
| Comments |
| Comment by Githook User [ 31/May/23 ] |
|
Author: {'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}Message: (cherry picked from commit be9568dd3c96f5727ef8cb0cfc598164e5bba69b) |
| Comment by Githook User [ 31/May/23 ] |
|
Author: {'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}Message: (cherry picked from commit be9568dd3c96f5727ef8cb0cfc598164e5bba69b) |
| Comment by Githook User [ 31/May/23 ] |
|
Author: {'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}Message: (cherry picked from commit be9568dd3c96f5727ef8cb0cfc598164e5bba69b) |
| Comment by Githook User [ 31/May/23 ] |
|
Author: {'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}Message: (cherry picked from commit be9568dd3c96f5727ef8cb0cfc598164e5bba69b) |
| Comment by Githook User [ 31/May/23 ] |
|
Author: {'name': 'Mikhail Shchatko', 'email': 'mikhail.shchatko@mongodb.com', 'username': 'MikhailShchatko'}Message: |