[SERVER-77731] merge OpStateAccumulator and InsertsOpStateAccumulator in OpObserver interface Created: 02/Jun/23 Updated: 29/Oct/23 Resolved: 13/Jun/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Benety Goh | Assignee: | Benety Goh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | techdebt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Assigned Teams: |
Storage Execution
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Execution Team 2023-06-12, Execution NAMR Team 2023-06-26 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
Most of the OpObserver methods use OpStateAccumulator with the exception of onInserts(), which uses InsertsOpStateAccumulator to hold multiple OpTimes. We should look into merging these two structs to provide a common data structure for all the OpObserver methods. One suggestion provided was to use a data structure such as absl::InlinedVector to combine the single/vector OpTime fields. |
| Comments |
| Comment by Githook User [ 13/Jun/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Githook User [ 11/Jun/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: InsertsOpStateAccumulator is now an alias to OpStateAccumulator |
| Comment by Githook User [ 09/Jun/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: |
| Comment by Benety Goh [ 02/Jun/23 ] |
|
This improvement was suggested while reviewing |