[SERVER-7775] Make special commands (inprog, killop, unlock) go through the standard command codepath Created: 27/Nov/12  Updated: 22/Mar/17  Resolved: 13/Apr/15

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.1.2

Type: Improvement Priority: Major - P3
Reporter: Spencer Brody (Inactive) Assignee: Adam Midvidy
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-17909 move RunOnAllShardsCommand to a separ... Closed
is depended on by DRIVERS-213 Make special commands (inprog, killop... Closed
is depended on by JAVA-1719 Re-implement Mongo.unlock and Mongo.i... Closed
is depended on by SERVER-17981 Remove support for pseudo-commands Backlog
is depended on by SERVER-17800 remove dead auditing functions for ps... Closed
Duplicate
is duplicated by SERVER-12734 CurrentOp (inprog) fails with wrapped... Closed
is duplicated by SERVER-17707 Rewrite inProg, unlockFsync & killOp ... Closed
is duplicated by SERVER-5466 Add commands for all $cmd.sys.* opera... Closed
is duplicated by SERVER-4760 Add commands for fsyncUnlock and fsyn... Closed
Related
related to SERVER-17951 db.currentOp() fails with read prefer... Closed
related to SERVER-19806 Query on $cmd.sys.inprog requires lim... Closed
related to SERVER-19810 mongos requires queries on $cmd.sys.i... Closed
related to SERVER-5811 Make a killCursors command Closed
is related to SERVER-20184 find commands on old-style system col... Closed
is related to DOCS-7106 Document the "killOp" command Closed
is related to DOCS-9425 Missing command information for fsync... Closed
is related to SERVER-20652 remove pseudocommand downconversion c... Closed
is related to DOCS-8007 Document currentOp command for 3.2+ Closed
Backwards Compatibility: Minor Change
Sprint: Platform 1 04/03/15, Platform 2 04/24/15
Participants:

 Description   

Currently inprog, killop, and unlock are special cased in the query handling code, rather than having a Command object with their implementation like ever other command.



 Comments   
Comment by Adam Midvidy [ 13/Apr/15 ]

All pseudocommands are now in master. The associated wire version bump will happen when the find/getMore commands are implemented in mongos.

As mentioned earlier, there is a behavior change in currentOp/inprog where the currentOp operation itself will now appear in the 'inprog' array of returned operations.

Comment by Githook User [ 13/Apr/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-7775 rewrite all pseudocommands to use admin db
Branch: master
https://github.com/mongodb/mongo/commit/daa19001b94db2153c1f0d85620fba0d5fbaada0

Comment by Githook User [ 13/Apr/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-7775 add currentOp command
Branch: master
https://github.com/mongodb/mongo/commit/1991daaff1a108d98f6e9e7414a16131e244bdd4

Comment by Adam Midvidy [ 09/Apr/15 ]

the behavior of currentOp/inprog is slightly changed, it will now show itself in the list of returned operations, much like the ps command on unix.

Comment by Githook User [ 06/Apr/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-7775 add killOp command
Branch: master
https://github.com/mongodb/mongo/commit/d6cd29d1fc0594657fcb2b69ce8334df85f9ba54

Comment by Githook User [ 30/Mar/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-7775 remove double auditing in fsyncUnlock
Branch: master
https://github.com/mongodb/mongo/commit/ef19e2624fdda864e33ceb5d88cf7a056e2b76b8

Comment by Githook User [ 26/Mar/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-7775 refactor fsyncUnlock to execute through standard command path
Branch: master
https://github.com/mongodb/mongo/commit/8a805598bbcb2ac20c345e0734c9fbd4c4722cb0

Comment by Githook User [ 25/Mar/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: Revert "SERVER-7775 refactor fsyncUnlock to execute through standard command path"

This reverts commit 5c48ea0d3fd6556eb0ba7686a9da6159f0814d08.
Branch: master
https://github.com/mongodb/mongo/commit/5e7aa5c9efdea28cc82ff8d0ea0e3a76cf5c94f8

Comment by Adam Midvidy [ 25/Mar/15 ]

Going to need to do a bunch of work in Strategy::handleSpecialNamespaces to make this work properly in mongos.

Comment by Adam Midvidy [ 25/Mar/15 ]

We're already going to bump the wire protocol for the find and getMore commands. We will include support for currentOp, killOp, and fsyncUnlock commands in that wire protocol version.

Comment by Githook User [ 25/Mar/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-7775 refactor fsyncUnlock to execute through standard command path
Branch: master
https://github.com/mongodb/mongo/commit/5c48ea0d3fd6556eb0ba7686a9da6159f0814d08

Generated at Thu Feb 08 03:15:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.