[SERVER-77825] optimize Decorations that are initialized to an "empty" state Created: 06/Jun/23 Updated: 29/Oct/23 Resolved: 24/Aug/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Assigned Teams: |
Service Arch
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Sprint: | Service Arch 2023-06-26, Service Arch 2023-07-10, Service Arch 2023-07-24, Service Arch 2023-08-07, Service Arch 2023-08-21, Service Arch 2023-09-04 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Description |
|
However, many decorations are initialized to an "empty" value. It's just that doing so isn't technically trivial, so we have to run a nop constructor for them. We do know that the buffer for Decorations is memset with 0-bytes. So we could invent a small wrapper type that considers the zero-filled representation to be valid and empty, and we would have no constructor work necessary for those. It's still unclear that doing this optimization would save initialization time. |
| Comments |
| Comment by Githook User [ 24/Aug/23 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Billy Donahue [ 23/Jun/23 ] |
|
May or may not be achievable without |
| Comment by Billy Donahue [ 23/Jun/23 ] |
|
Expediting as a speculative optimization for 7.0 release. |
| Comment by Billy Donahue [ 06/Jun/23 ] |
|
carries on the work of |