[SERVER-78179] Mandatory Code Cleanup for Defunct Online MovePrimary Project Created: 16/Jun/23  Updated: 29/Oct/23  Resolved: 03/Jul/23

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: 7.1.0-rc0
Fix Version/s: 7.1.0-rc0, 7.0.0-rc7

Type: Task Priority: Major - P3
Reporter: Brett Nawrocki Assignee: Brett Nawrocki
Resolution: Fixed Votes: 0
Labels: sharding-nyc-subteam1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
depends on SERVER-78487 Fully disable featureFlagOnlineMovePr... Closed
is depended on by SERVER-77713 Complete TODO listed in SERVER-77115 Closed
is depended on by SERVER-77716 Complete TODO listed in SERVER-74757 Closed
is depended on by SERVER-77717 Complete TODO listed in SERVER-74933 Closed
is depended on by SERVER-78180 Desirable Code Cleanup for Defunct On... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0
Participants:

 Description   

Now that the online movePrimary project will be moving in a different direction, all of the existing code that's lingering in other files should be removed to reduce complexity and simplify maintenance. This includes the following:

  • featureFlagOnlineMovePrimaryLifecycle and all code that is active while it is on (primarily in move_primary_coordinator.cpp)
  • jstests that rely on featureFlagOnlineMovePrimaryLifecycle
  • References to movePrimary metrics in sharding_data_transform_cumulative_metrics
  • movePrimary in log_component.h
  • movePrimaryRecipients in known_collections.h
  • Error codes added during the online movePrimary project
  • Namespace string constants added during the online movePrimary project
  • References to MovePrimaryDonorService and MovePrimaryRecipientService in mongod_main.cpp


 Comments   
Comment by Githook User [ 05/Jul/23 ]

Author:

{'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}

Message: SERVER-78179 Code Cleanup for Online MovePrimary

(cherry picked from commit eea7077cad2f667ddeb569573dc25f52321cf97d)
Branch: v7.0
https://github.com/mongodb/mongo/commit/38e583c854ef1da69c1be389fee3773524400cff

Comment by Githook User [ 03/Jul/23 ]

Author:

{'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}

Message: SERVER-78179 Code Cleanup for Online MovePrimary
Branch: EVG-17874-taskgen-test
https://github.com/mongodb/mongo/commit/eea7077cad2f667ddeb569573dc25f52321cf97d

Comment by Githook User [ 30/Jun/23 ]

Author:

{'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}

Message: SERVER-78179 Code Cleanup for Online MovePrimary
Branch: master
https://github.com/mongodb/mongo/commit/eea7077cad2f667ddeb569573dc25f52321cf97d

Generated at Thu Feb 08 06:37:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.