[SERVER-78204] Modify ScopedCollectionAcquisition to be a smart pointer that's passed by value Created: 19/Jun/23  Updated: 29/Oct/23  Resolved: 04/Jul/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Jordi Olivares Provencio Assignee: Jordi Olivares Provencio
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-74030 Consider a better way to express recu... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution EMEA Team 2023-06-26, Execution EMEA Team 2023-07-10
Participants:

 Description   

In order to implement proper getMore functionality with the Shard Role API we need to modify ScopedCollectionAcquisition to be a smart pointer.

Right now the class is already "smart pointer"-like, but lacks the reference counting logic. This means that it automatically removes the acquisition once it goes out of scope, but this makes implementing getMore impossible since the scope is not preserved anywhere.



 Comments   
Comment by Githook User [ 04/Jul/23 ]

Author:

{'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}

Message: SERVER-78204 Refactor acquisitions to be a smart pointer
Branch: master
https://github.com/mongodb/mongo/commit/e89dcf1d6fcefff48ec6f5f87fc8f29b895b8015

Generated at Thu Feb 08 06:37:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.