[SERVER-78390] Decorable subsystem refactoring Created: 23/Jun/23  Updated: 29/Oct/23  Resolved: 21/Jul/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-77355 GDB pretty printer must gracefully sk... Closed
is depended on by SERVER-76782 emplace the DecorationContainer into ... Backlog
is depended on by SERVER-77825 optimize Decorations that are initial... Closed
is depended on by SERVER-79328 Decorable refactor UBSAN fix: pass vo... Closed
Problem/Incident
Assigned Teams:
Service Arch
Backwards Compatibility: Minor Change
Sprint: Service Arch 2023-07-10, Service Arch 2023-07-24
Participants:
Linked BF Score: 162

 Description   

Decorable is a difficult component currently.
This ticket covers internal improvements to enable maintenance on it.

It's not an optimization, but the simplification has made optimization opportunities easier to see and these soft gains should be locked in as a separate commit.

combining the three decorable-related headers into one, which reduces friction for further implementation changes and reliance on friend relationships etc.

Rename some internal elements of the Decorable helpers etc.

Also remove some of the unusual code patterns in the implementation.

(Broken out from SERVER-76782)



 Comments   
Comment by Githook User [ 20/Jul/23 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-78390 Refactor of Decoration
Branch: master
https://github.com/mongodb/mongo/commit/f1f16c7b89cdb4653a94ec5636aa6baed856f5ab

Comment by Billy Donahue [ 19/Jul/23 ]

Pretty printer problem caused revert. Forgot something in there I guess. Will try again.

Comment by Githook User [ 19/Jul/23 ]

Author:

{'name': 'Uladzimir Makouski', 'email': 'uladzimir.makouski@mongodb.com', 'username': 'umakouski'}

Message: Revert "SERVER-78390 Refactor of Decoration"

This reverts commit 6aa81b7a5d8e5cc634e35f24a0b98efc3a83b865.
Branch: master
https://github.com/mongodb/mongo/commit/bd221c26d81b355d472bc2d34d786a6116c13ac2

Comment by Githook User [ 18/Jul/23 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-78390 Refactor of Decoration
Branch: master
https://github.com/mongodb/mongo/commit/6aa81b7a5d8e5cc634e35f24a0b98efc3a83b865

Generated at Thu Feb 08 06:38:14 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.