[SERVER-78406] Rename the 'sampleRate' option for configureQueryAnalyzer command to 'samplesPerSecond' Created: 23/Jun/23  Updated: 29/Oct/23  Resolved: 27/Jun/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0, 7.0.0-rc6

Type: Task Priority: Major - P3
Reporter: Cheahuychou Mao Assignee: Cheahuychou Mao
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
is related to MONGOSH-1499 Make analyzeShardKey shell helper sup... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0
Sprint: Sharding NYC 2023-06-26, Sharding NYC 2023-07-10
Participants:

 Description   

SERVER-78265 is adding new options to 'sampleRate' and 'sampleSize' to the analyzeShardKey command, where 'sampleRate' is a double in range (0, 1] representing the proportion of the documents in the collection to sample. This definition aligns with what other commands use (e.g. the profiler and analyze command). For usability purposes, the 'sampleRate' option for the configureQueryAnalyzer command should be renamed to 'samplesPerSecond' so it is self-explanatory and cannot be confused with the 'sampeRate' option for the analyzeShardKey command which belongs to the same feature being introduced in PM-1858.



 Comments   
Comment by Githook User [ 03/Jul/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: fix(shell-api): rename configureQueryAnalyzer option to match server MONGOSH-1499 (#1500)

SERVER-78406 renamed the option from `sampleRate` to `samplesPerSecond`.
Consequently, we should do the same here.
Branch: use-devtools-shared
https://github.com/mongodb-js/mongosh/commit/14d0a11e8aef576ba5ed56b852ca0dd7b84429cb

Comment by Githook User [ 28/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: fix(shell-api): rename configureQueryAnalyzer option to match server MONGOSH-1499 (#1500)

SERVER-78406 renamed the option from `sampleRate` to `samplesPerSecond`.
Consequently, we should do the same here.
Branch: main
https://github.com/mongodb-js/mongosh/commit/14d0a11e8aef576ba5ed56b852ca0dd7b84429cb

Comment by Githook User [ 27/Jun/23 ]

Author:

{'name': 'Anna Henningsen', 'email': 'anna.henningsen@mongodb.com', 'username': 'addaleax'}

Message: chore(shell-api): rename configureQueryAnalyzer option to match server

SERVER-78406 renamed the option from `sampleRate` to `samplesPerSecond`.
Consequently, we should do the same here.
Branch: server-78406-dev
https://github.com/mongodb-js/mongosh/commit/b48c9bd5146c8595ae36762bb20eab2b14c167c8

Comment by Githook User [ 27/Jun/23 ]

Author:

{'name': 'Cheahuychou Mao', 'email': 'mao.cheahuychou@gmail.com', 'username': 'cheahuychou'}

Message: SERVER-78406 Rename the 'sampleRate' option for configureQueryAnalyzer command to 'samplesPerSecond'

(cherry picked from commit 55685ede425e56772a5d7d1a52597dbbcd0d4cc2)
Branch: v7.0
https://github.com/mongodb/mongo/commit/71372d665fe6481f57964a92f96fcd3871b7d43e

Comment by Githook User [ 27/Jun/23 ]

Author:

{'name': 'Cheahuychou Mao', 'email': 'mao.cheahuychou@gmail.com', 'username': 'cheahuychou'}

Message: SERVER-78406 Rename the 'sampleRate' option for configureQueryAnalyzer command to 'samplesPerSecond'
Branch: master
https://github.com/mongodb/mongo/commit/55685ede425e56772a5d7d1a52597dbbcd0d4cc2

Generated at Thu Feb 08 06:38:16 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.