[SERVER-78437] OperationContext::markKilled(ErrorCodes::Error) should take a Status that contains an error message Created: 26/Jun/23 Updated: 27/Oct/23 Resolved: 22/Aug/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Dianna Hohensee (Inactive) | Assignee: | Backlog - Service Architecture |
| Resolution: | Works as Designed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Assigned Teams: |
Service Arch
|
||||||||||||
| Sprint: | Execution NAMR Team 2023-07-10, Execution NAMR Team 2023-07-24, Execution NAMR Team 2023-08-07 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 10 | ||||||||||||
| Description |
|
Currently OperationContext::markKilled(ErrorCodes::Error) just sets a default "operation was interrupted". It would be much more informative to have markKilled() callers explain why an operation is terminated, so a better error message/explanation can be forwarded to the user. |
| Comments |
| Comment by Jason Chan [ 22/Aug/23 ] |
|
From what I understand, it was an original design choice to make it so we use a single error code for killing/interrupting operations, as the hope is that all operations should react the same way when being interrupted and shouldn't need the higher level context. I think if the goal is to improve traceability for BFs, I hope PM-3400 will help with this which is slated for the next few quarters. |
| Comment by Dianna Hohensee (Inactive) [ 07/Jul/23 ] |
|
The PR contains my work, putting this back on the backlog user. I made most of the changes, but forgot to compile with enterprise, so need to work through those compilation errors. And then tidy up the code. |