[SERVER-78486] Replace parseNamespaceFrom* calls with deserialize Created: 27/Jun/23 Updated: 29/Oct/23 Resolved: 29/Aug/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Hugh Tong (Inactive) | Assignee: | Hugh Tong (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | ntdi_must_have | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Assigned Teams: |
Serverless
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Sprint: | Server Serverless 2023-07-24, Server Serverless 2023-08-21, Server Serverless 2023-09-04 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Story Points: | 3 | ||||||||||||||||||||||||
| Description |
|
NamespaceStringUtil::parseNamespaceFromRequest() is called in multiple command contexts, but it doesn't currently call `serializeForCommands` because no serialization context is provided. We need to look through (IDL and hand rolled/non-IDL) requests and pass serialization-context pertinent data (ie. value of `expectPrefix`, whether or not tenantId is on the $tenant/security token) for commands that require this. We likely don't need to worry about any calls related to sharding or outside our target command list. Targeted tests are currently not behaving as expected without this change, so those tests have a dependency on this fix. |
| Comments |
| Comment by Githook User [ 25/Aug/23 ] |
|
Author: {'name': 'Hugh Tong', 'email': 'hugh.tong@mongodb.com', 'username': 'cortrain'}Message: |