[SERVER-78574] Refactor RecordStore::ns to return a NamespaceString object Created: 30/Jun/23 Updated: 29/Oct/23 Resolved: 07/Jul/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Mathis Bessa | Assignee: | Mathis Bessa |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Sprint: | Server Serverless 2023-07-10 | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
WiredTigerRecordStore::ns is currently returning a string after we serialize from a string. That returned string object from `ns()` is then used for logging purposes. We should refactor the method to return a NamespaceString object directly and then use `toStringForLogging` or `toStringForErrorMessage` when needed.
|
| Comments |
| Comment by Githook User [ 07/Jul/23 ] |
|
Author: {'name': 'mathisbessamdb', 'email': 'mathis.bessa@mongodb.com', 'username': 'mathisbessamdb'}Message: |
| Comment by Mathis Bessa [ 06/Jul/23 ] |
|
kaloian.manassiev@mongodb.com I have created SERVER-78731 to address your comment and assigned it to Storage Execution EMEA backlog, per our off line conversation. Thank you ! |
| Comment by Kaloian Manassiev [ 03/Jul/23 ] |
|
Can we please get rid of the `ns()` method on the RecordStore rather than doubling down on it? RecordStores, in their lifetime can belong to differently-named collections with the same UUID, so it is not very meaningful to expose the `ns()` first class. If anything, for the purposes of logging we should just use the same resolution we do for the ResourceIds. |