[SERVER-78677] Change SerializationOptions to a const ref Created: 05/Jul/23 Updated: 29/Oct/23 Resolved: 31/Jul/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Maddie Zechar | Assignee: | Maddie Zechar |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | QO 2023-07-24, QO 2023-08-07 | ||||||||
| Participants: | |||||||||
| Description |
|
SerializationOptions is passed by value because the struct was originally so small, the cost was insignificant. Now that it has grown so much, it makes sense to pass it as a const ref. In places where SerializationOptions needs to be updated/changed, we can just create a new instance. |
| Comments |
| Comment by Githook User [ 28/Jul/23 ] |
|
Author: {'name': 'Maddie Zechar', 'email': 'maddie.zechar@mongodb.com', 'username': 'madelinezec'}Message: |