[SERVER-78727] Update timeout calculator to handle `max_duration_pass ` Created: 06/Jul/23 Updated: 13/Jul/23 Resolved: 10/Jul/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.0.0-rc7, 7.0.0-rc8, 4.4.24, 5.0.20, 6.0.9 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Jeffrey Zambory | Assignee: | Jeffrey Zambory |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Backport Requested: |
v7.0, v6.0, v5.0, v4.4, v4.2
|
||||||||
| Sprint: | DAG 2023-07-10 | ||||||||
| Participants: | |||||||||
| Linked BF Score: | 156 | ||||||||
| Story Points: | 1 | ||||||||
| Description |
|
We currently only track and make available for use in the timeout calculator the average time that a test took to pass recently. This metric is fine to use for most task timeout calculations as tests for the most part are supposed to have a set runtime they adhere to and deviations from that are incorrect. However, tests such as benchmarks can have a semi-random runtime instead and can vary pretty widely from run to time. This makes it difficult for the task generator to split up benchmark tasks effectively and can cause semi-random timeouts and also task groups with very uneven wall clock runtimes in them. To help minimize the risk of these timeouts, we instead want to begin bucketing based upon the recent max runtime of benchmark tests. This should be a better metric to use in regards to these benchmark tests and lead to less of a risk of new BFs that arise and then closed as noise. To support this, we're exposing a new parameter called `max_duration_pass` as part of the task runtime history and need to update the Python buildscript code in the mongo repo to expect this new parameter. The task generation work will be done in a separate ticket. |
| Comments |
| Comment by Jeffrey Zambory [ 13/Jul/23 ] |
|
tommaso.tocci@mongodb.com Sorry about that! Just fixed all the backport tickets and gave them the correct status. Also updated the description to call out what this is doing. |
| Comment by Githook User [ 10/Jul/23 ] |
|
Author: {'name': 'Jeff Zambory', 'email': 'jeff.zambory@mongodb.com', 'username': ''}Message: (cherry picked from commit 8cad9c092d31ed5322e81669655d72d7f0270927) |
| Comment by Githook User [ 10/Jul/23 ] |
|
Author: {'name': 'Jeff Zambory', 'email': 'jeff.zambory@mongodb.com', 'username': ''}Message: (cherry picked from commit 8cad9c092d31ed5322e81669655d72d7f0270927) |
| Comment by Githook User [ 10/Jul/23 ] |
|
Author: {'name': 'Jeff Zambory', 'email': 'jeff.zambory@mongodb.com', 'username': ''}Message: (cherry picked from commit 8cad9c092d31ed5322e81669655d72d7f0270927) |
| Comment by Githook User [ 10/Jul/23 ] |
|
Author: {'name': 'Jeff Zambory', 'email': 'jeff.zambory@mongodb.com', 'username': ''}Message: |
| Comment by Githook User [ 07/Jul/23 ] |
|
Author: {'name': 'Jeff Zambory', 'email': 'jeff.zambory@mongodb.com', 'username': ''}Message: |