[SERVER-78998] Refactor checking the value of 'internalQueryFrameworkControl' throughout query code Created: 14/Jul/23  Updated: 05/Dec/23  Resolved: 21/Aug/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0, 7.0.5

Type: Task Priority: Major - P3
Reporter: Kristina Znam (Inactive) Assignee: Zixuan Zhuang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Assigned Teams:
Query Execution
Backwards Compatibility: Fully Compatible
Backport Requested:
v7.0
Sprint: QE 2023-08-07, QE 2023-08-21, QE 2023-09-04
Participants:

 Description   

When initializing our CanonicalQuery for query planning, we cannot check the 'internalQueryFrameworkControl' parameter more than once, because this parameter is runtime configurable and can change between the two checks (the value is not guaranteed to be constant throughout the lifetime of a query).

One option that was discussed was adding it as a decorator on the operation context or on the expression context. 



 Comments   
Comment by Githook User [ 05/Dec/23 ]

Author:

{'name': 'Ivan Fefer', 'email': 'ivan.fefer@mongodb.com', 'username': 'Fefer-Ivan'}

Message: SERVER-78998 Refactor SBE-Related Server Parameters into Operation Context

GitOrigin-RevId: 4d6b369eac0284c7a1bda8dd56357eb990c73425
Branch: v7.0
https://github.com/mongodb/mongo/commit/ecce7364fc28c026a60687b6d421c7344cf9380e

Comment by Ivan Fefer [ 05/Dec/23 ]

Requesting backport to 7.0 as this is a required for correctness of SERVER-83777 which should be backported to 7.0 to help with sbe plan cache.

Comment by Githook User [ 21/Aug/23 ]

Author:

{'name': 'Zixuan Zhuang', 'email': 'zixuan.zhuang@mongodb.com', 'username': 'leozzx'}

Message: SERVER-78998 Refactor SBE-Related Server Parameters into Operation Context
Branch: master
https://github.com/mongodb/mongo/commit/2dda3a5d588bcb12bb79ce61e85d1e025321803a

Comment by Justin Seyster [ 21/Jul/23 ]

prithwish.dan@mongodb.com, I discussed with mihai.andrei@mongodb.com that if we add a decorator to attach compatibility info to a query, it would be useful to also include the information from featureFlagSbeFull, internalQuerySlotBasedExecutionDisableGroupPushdown, and internalQuerySlotBasedExecutionDisableLookupPushdown. Currently, the SBE pushdown checks will sometimes load these values (which are also runtime configurable) multiple times during query execution and would also benefit from this refactor.

Generated at Thu Feb 08 06:39:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.