[SERVER-79010] after we reopen wiredtiger_open, we shold close the old connection(get bywiredtiger_open ) Created: 17/Jul/23  Updated: 19/Dec/23  Resolved: 18/Dec/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major - P3
Reporter: y yz Assignee: Backlog - Storage Execution Team
Resolution: Works as Designed Votes: 0
Labels: former-storex-namer
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File image-2023-07-17-20-48-00-270.png     PNG File image-2023-07-17-20-49-23-212.png    
Issue Links:
Related
is related to WT-12163 Improve documentation of state after ... Backlog
Assigned Teams:
Storage Execution
Operating System: ALL
Participants:

 Description   

after we reopen wiredtiger_open, we shold close the old connection(get bywiredtiger_open )

 

if we not close the old open wiredtiger, There will be a Resource leak.

 

 



 Comments   
Comment by y yz [ 19/Dec/23 ]

louis.williams@mongodb.com 
got it, However, I recommend adding comments to the code in function WiredTigerKVEngine::_openWiredTiger, thanks.

Reading the code intuitively feels that there is a resource leak

Comment by Louis Williams [ 18/Dec/23 ]

1147952115@qq.com, thank you for your contribution. Unfortunately, we have determined that the current code works correctly and does not require any changes. This is explained in detail in WT-12163. Thanks again, and we look forward to your future contributions!

Comment by Louis Williams [ 03/Nov/23 ]

1147952115@qq.com I'm going to send this to the WiredTiger engineers to determine what the contract is for this API.

Comment by y yz [ 03/Nov/23 ]

hi, louis.williams@mongodb.com 

I merge the code to 4.2.24, Follow your test procedure, test is ok.

 

thanks

Comment by y yz [ 03/Nov/23 ]

hi, louis.williams@mongodb.com 

What version are you using 4.2.x?

I did the test with the 5.0.13 code as you said, it's ok, No problem.
I compiled the wiredtiger code, did a demo test, and it was fine.

 

 

Comment by Louis Williams [ 02/Nov/23 ]

1147952115@qq.com I replied to your pull request, but I do not believe this change is correct. Please let me know what you think.

Comment by y yz [ 13/Oct/23 ]

hi, Chris Kelly

Do we have the conclusion of this PR? 

thanks.

Comment by Chris Kelly [ 18/Jul/23 ]

Thanks for the pull request 1147952115@qq.com! As always, your contributions are appreciated.
I'm going to pass this to the relevant team for review.

Christopher

Comment by y yz [ 17/Jul/23 ]

the PR code:
https://github.com/mongodb/mongo/pull/1562

Comment by y yz [ 17/Jul/23 ]

in function WiredTigerKVEngine::_openWiredTiger, we open wiredtiger many times, but we do not close the old connections.

for example:

 

 

Generated at Thu Feb 08 06:39:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.