[SERVER-79027] Improve the perf of getOrGenerateSampleId() in the common case Created: 17/Jul/23  Updated: 13/Nov/23

Status: Open
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Drew Paroski Assignee: Cheahuychou Mao
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File getOrGenerateSampleId.png    
Issue Links:
Depends
Assigned Teams:
Sharding NYC
Sprint: Sharding NYC 2023-09-04, Sharding NYC 2023-09-18, Sharding NYC 2023-10-02, Sharding NYC 2023-10-16, Sharding NYC 2023-10-30, Cluster Scalability 2023-11-13
Participants:

 Description   

Based on my limited understanding, it seems that getOrGenerateSampleId() in the common case returns boost::none.

Unfortunately, supportsPersistingSampledQueries() is slower than it ideally should be for the common case.

getOrGenerateSampleId() showed up on some of the flamegraphs on PERF-4259. Here is a screenshot:

The goal of this task is to make getOrGenerateSampleId() faster in the common case where getOrGenerateSampleId() returns boost::none.


Generated at Thu Feb 08 06:39:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.