[SERVER-79352] (SA) Allow dual `MetricTree` based on role Created: 26/Jul/23  Updated: 05/Feb/24

Status: In Progress
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Paolo Polato Assignee: Billy Donahue
Resolution: Unresolved Votes: 0
Labels: auto-reverted, pm-635-milestone-3
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-84485 Place all Metrics in appropriate Metr... Backlog
is depended on by SERVER-78673 Remove shims from Authorization Manag... Closed
Problem/Incident
Related
is related to SERVER-79353 (SA) Allow dual `ServerStatusSectionR... Backlog
is related to SERVER-78976 (SA) Adapt command registry to suppor... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
SERVER-82303 Support for multiple MetricTree Sub-task In Code Review Billy Donahue  
Assigned Teams:
Service Arch
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2023-08-21, Service Arch 2023-10-02, Service Arch 2023-10-16, Service Arch 2023-10-30, Service Arch 2023-11-13, Service Arch 2023-11-27, Service Arch 2023-12-11, Service Arch 2023-12-25, Service Arch 2024-01-08, Service Arch 2024-01-22, Service Arch 2024-02-05, Service Arch 2024-02-19
Participants:
Linked BF Score: 164

 Description   

The response provided by the serverStatus command includes a "Metrics" section, which reflects the state of a set of counters (ServerStatusMetric objects) managed by a process-global registry (the globalMetricTree).

Such infrastructure needs to be adapted to support a scenario where a mongod process provides role-specific metrics based on the port serving a serverStatus request.



 Comments   
Comment by Billy Donahue [ 30/Oct/23 ]

reopening as subtask still in progress

Comment by Githook User [ 27/Oct/23 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-79352 ClusterRole for MetricTree
Branch: master
https://github.com/mongodb/mongo/commit/8be77d7fd6f39fa70f8d061b58b997dca1ed1bf7

Comment by Billy Donahue [ 26/Oct/23 ]

I believe the revert was caused by the `auth` test being sensitive to logging at LogSeverity D3.
It should always be safe to emit even extremely verbose log statements at that severity, and tests should be resilient to it. But that's life. I can remove the verbose logging and try again this time, but it should be addressed at some point, as reverting and recommitting over this is a productivity drain on several people.

recommit:
https://github.com/10gen/mongo/pull/16428

Comment by Githook User [ 24/Oct/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com', 'username': ''}

Message: Revert "SERVER-79352 ClusterRole for MetricTree"

This reverts commit 63ceb3543106ef7e383d7a484c8199b740b40a3b.
Branch: master
https://github.com/mongodb/mongo/commit/ead901551a81b9121c9629ffb58c089efac3ebb5

Comment by Githook User [ 23/Oct/23 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-79352 ClusterRole for MetricTree
Branch: master
https://github.com/mongodb/mongo/commit/63ceb3543106ef7e383d7a484c8199b740b40a3b

Comment by Billy Donahue [ 22/Aug/23 ]

The description says that the globalMetricTree has to be adapted, but I would like to know if there is any design work done on what the metric tree will look like after the merger to inform the adaptation that needs to be done. Do the roles become sibling subtrees of a common root? There are many possibilities.

Generated at Thu Feb 08 06:40:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.