[SERVER-79508] Investigate removing StubMongoProcessInterface from production use Created: 31/Jul/23 Updated: 25/Jan/24 |
|
| Status: | Backlog |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Alyssa Clark | Assignee: | Backlog - Query Integration |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | qi-tech-debt, query-skunkworks | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Query Integration
|
||||||||
| Participants: | |||||||||
| Description |
|
This check didn't end up being feasible to change. We need to investigate how to get rid of StubMongoProcessInterface from being used in production in the first place. |
| Comments |
| Comment by Gil Alon [ 30/Nov/23 ] |
|
This issue came up again in |
| Comment by Ted Tuckman [ 12/Oct/23 ] |
|
We would like to move toward a world in which we don't use the stub in production – if there's a straightforward way of changing the existing explicit checks great, if not we can postpone this. |
| Comment by Maddie Zechar [ 12/Oct/23 ] |
|
Ok if this is a step toward removing the stub interface, heard.
I checked in with Jacob who wrote the original code and disagreed that type checking is slow.
But I'll move forward in the interest of getting rid of the stub interface eventually? cc ted.tuckman@mongodb.com |
| Comment by Alyssa Clark [ 11/Oct/23 ] |
|
Ideally we wouldn't use the stub interface in production at all, so this is a step towards that. I don't remember much context beyond that - ted.tuckman@mongodb.com IIRC you were advocating for this ticket being created, do you remember any other reasoning for it? |
| Comment by Maddie Zechar [ 11/Oct/23 ] |
|
Got it - could you please explain why you feel that the code linked is bad? |
| Comment by Alyssa Clark [ 11/Oct/23 ] |
|
This ticket is just about avoiding the type checking for the stub interface. |
| Comment by Maddie Zechar [ 11/Oct/23 ] |
|
alyssa.wagenmaker@mongodb.com – want to confirm before BF days tmrw, is the issue here that we shouldn't have stubs in production at all? Or the issue is with type checking subclasses? |