[SERVER-79574] Pass serialization context into makeFromFindCommand Created: 01/Aug/23  Updated: 04/Aug/23  Resolved: 04/Aug/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Hugh Tong (Inactive) Assignee: Hugh Tong (Inactive)
Resolution: Duplicate Votes: 0
Labels: ntdi_must_have
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-77723 Turn parseNamespaceFromRequest calls ... Closed
Sprint: Server Serverless 2023-08-07
Participants:

 Description   

makeFromFindCommand is used by FindCmd and directly calls FindCommandRequest::parse() without passing in a serialization context.  While we currently update the serialization context with VTS after constructing the find request, this doesn't work if we intend to check whether the supplied tenantId is received from $tenant or the security token/VTS (nonPrefixedTenantId).  We need to pass in a prepared serialization context to the parse() function to ensure its values can be consumed by ::deserializeForCommands() during parsing.



 Comments   
Comment by Hugh Tong (Inactive) [ 04/Aug/23 ]

The work for SERVER-79574 cannot be safely and efficiently separated from SERVER-77723, and as such is absorbed into SERVER-77723.

Generated at Thu Feb 08 06:41:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.